Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connectQueryRules): improve tracked refinement type #3648

Merged
merged 1 commit into from
Apr 3, 2019
Merged

fix(connectQueryRules): improve tracked refinement type #3648

merged 1 commit into from
Apr 3, 2019

Conversation

francoischalifour
Copy link
Member

@francoischalifour francoischalifour requested a review from a team April 3, 2019 09:18
@francoischalifour francoischalifour force-pushed the fix/connectQueryRules-TrackedRefinement-type branch from 905017c to 5406fa1 Compare April 3, 2019 09:19
@algobot
Copy link
Contributor

algobot commented Apr 3, 2019 •
edited
Loading

Deploy preview for instantsearchjs ready!

Built with commit a47ca74

https://deploy-preview-3648--instantsearchjs.netlify.com

@algolia algolia deleted a comment from algobot Apr 3, 2019
@francoischalifour francoischalifour force-pushed the fix/connectQueryRules-TrackedRefinement-type branch from 5406fa1 to 055af70 Compare April 3, 2019 14:25
@francoischalifour francoischalifour requested a review from a team April 3, 2019 14:26
@Haroenv
Copy link
Contributor

Haroenv commented Apr 3, 2019

(looks like tsc doesn't like your change yet)

@francoischalifour francoischalifour force-pushed the fix/connectQueryRules-TrackedRefinement-type branch from 055af70 to a47ca74 Compare April 3, 2019 14:45
@francoischalifour francoischalifour merged commit e16ad57 into develop Apr 3, 2019
@francoischalifour francoischalifour deleted the fix/connectQueryRules-TrackedRefinement-type branch April 3, 2019 15:11
francoischalifour added a commit that referenced this pull request Apr 11, 2019
@francoischalifour
v3.3.0
172783c 
# [3.3.0](v3.2.1...v3.3.0) (2019-04-11)

### Bug Fixes

* **connectQueryRules:** improve tracked refinement type ([#3648](#3648)) ([e16ad57](e16ad57))
* **currentRefinements:** don't rely on  ([#3672](#3672)) ([cd64bcf](cd64bcf))
* **queryRuleCustomData:** add default template ([#3650](#3650)) ([83e9eaa](83e9eaa))
* **QueryRuleCustomData:** pass data as object to templates ([#3647](#3647)) ([b8f8b4e](b8f8b4e))
* **queryRules:** fix types and stories ([#3670](#3670)) ([ba6e2e6](ba6e2e6))
* **routing:** apply windowTitle on first load ([#3669](#3669)) ([d553502](d553502)), closes [#3667](#3667)
* **routing:** support parsing URLs with up to 100 refinements ([#3671](#3671)) ([6ddcfb6](6ddcfb6))
* **RoutingManager:** avoid stale uiState ([#3630](#3630)) ([e1588aa](e1588aa))
* **types:** improve InstantSearch types ([#3651](#3651)) ([db9b91e](db9b91e))
* **ua:** Update the User-Agent to use the new format ([#3616](#3616)) ([ab84c57](ab84c57))

### Features

* **infiniteHits:** add previous button ([#3645](#3645)) ([2c9e38d](2c9e38d))
* **queryRules:** add connectQueryRules connector ([#3597](#3597)) ([924cd99](924cd99)), closes [#3599](#3599) [#3600](#3600)
* **queryRules:** add context features to Query Rules ([#3617](#3617)) ([922879e](922879e)), closes [#3602](#3602)

### Reverts

* feat(infiniteHits): add previous button ([214c0fc](214c0fc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrugg tkrugg tkrugg left review comments

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoischalifour @algobot @Haroenv @tkrugg